Skip to content

Add layer and extension checks on instance creation#78

Merged
gpx1000 merged 3 commits intoKhronosGroup:mainfrom
asuessenbach:01_instance_creation
Jul 5, 2025
Merged

Add layer and extension checks on instance creation#78
gpx1000 merged 3 commits intoKhronosGroup:mainfrom
asuessenbach:01_instance_creation

Conversation

@asuessenbach
Copy link
Copy Markdown
Contributor

Note 1: you should mention the existence of the install_dependencies scripts in the readme.md!

Note 2: not all projects are successfully building. 00_base_code, for example, fails.

@gpx1000
Copy link
Copy Markdown
Contributor

gpx1000 commented Jul 2, 2025

Thanks @asuessenbach I'll add the mention to the readme and we have a fix for 00_base_code in the CI PR so fix for that is incoming. This PR looks good to me, we'll need to work this change into all of the other code files as well that reproduces it.

@asuessenbach
Copy link
Copy Markdown
Contributor Author

we'll need to work this change into all of the other code files as well that reproduces it.

I can extend this PR accordingly.

@asuessenbach
Copy link
Copy Markdown
Contributor Author

The function createInstance in 02_validation_layers.cpp doesn't need a fix, but just some checks.

Added them right now. If that looks ok, I can carry that over to the other sources.

@asuessenbach asuessenbach force-pushed the 01_instance_creation branch from debe009 to 5cd2086 Compare July 3, 2025 07:41
@gpx1000
Copy link
Copy Markdown
Contributor

gpx1000 commented Jul 3, 2025

That looks great to me! Thanks for the work! I'm working on new chapters right now and have begun to enforce using vulkanconfig to set the validation layers so that change should only need to propagate through compute_shaders. If that gets tedious, I'm happy to do the propagation.

@asuessenbach asuessenbach changed the title Fix Instance creation in 01_instance_creation.cpp Add layer and extension checks on instance creation Jul 3, 2025
@gpx1000 gpx1000 merged commit 07d4d97 into KhronosGroup:main Jul 5, 2025
@asuessenbach asuessenbach deleted the 01_instance_creation branch July 7, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants